[PATCH] D99738: [HIP] remove overloaded abs in header

2021-04-01 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85ff35a9529a: [HIP] remove overloaded abs in header (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D99738: [HIP] remove overloaded abs in header

2021-04-01 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM, thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99738/new/ https://reviews.llvm.org/D99738 ___ cfe-commits mailing list cfe-c

[PATCH] D99738: [HIP] remove overloaded abs in header

2021-04-01 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. I have tested removing this did not cause regressions in our CI. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99738/new/ https://reviews.llvm.org/D99738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D99738: [HIP] remove overloaded abs in header

2021-04-01 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, JonChesterfield, ashi1. yaxunl requested review of this revision. This function seems to be introduced by accident by https://github.com/llvm/llvm-project/commit/aa2b593f1495a972a4a592952760ec9d5f7c01f1 Such overloaded abs function did n