[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

kpet closed this revision. kpet added a comment. Committed as https://github.com/llvm/llvm-project/commit/9d25ce743a95a9ad03c0a4b3a705f85c2de52398. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99425/new/ https://reviews.llvm.org/D99425 _

[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

kpet added a comment. Thanks! I'll commit the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99425/new/ https://reviews.llvm.org/D99425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

azabaznov accepted this revision. azabaznov added a comment. Looks good to me. Thanks! > Without this change, opencl-c.h cannot be parsed with -cl-std=CL3.0 as the > write_only image3d_t type is not enabled. This should be fixed in the following up patches to check for `__opencl_c_3d_image_wri

[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

kpet added a comment. @azabaznov Without this change, `opencl-c.h` cannot be parsed with `-cl-std=CL3.0` as the `write_only image3d_t` type is not enabled. The type is currently enabled via `cl_khr_3d_image_writes`. See https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Basic/Op

[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

azabaznov added a comment. Thanks for  the patch! Sorry for the delay Can you please elaborate on what issue you are trying to resolve with this fix? You're trying to emit diagnostics for `cl_khr_3d_image_writes` for OpenCL C 3.0? FYI `cl_khr_3d_image_writes` should have no effect in `-cl-ext`

[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

kpet added a comment. Thanks! I'll wait for a couple of days before committing then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99425/new/ https://reviews.llvm.org/D99425 ___ cfe-commits mailing list

[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! I would like to hold off committing this for a day or two to see if there is any input from @azabaznov or anyone else. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

kpet created this revision. kpet added a reviewer: Anastasia. kpet added a project: clang. Herald added subscribers: ldrumm, kristof.beyls, yaxunl. kpet requested review of this revision. Herald added a subscriber: cfe-commits. Ensure that the cl_khr_3d_image_writes pragma is enabled by making cl_