kpet added a comment. @azabaznov Without this change, `opencl-c.h` cannot be parsed with `-cl-std=CL3.0` as the `write_only image3d_t` type is not enabled. The type is currently enabled via `cl_khr_3d_image_writes`. See https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Basic/OpenCLImageTypes.def#L68. It may be that we want to redesign this such that the type be enabled by the feature macro (or via another mechanism) and have the extension enable the feature macro internally but this would require more thinking and is probably best done as a follow-up IMHO (maybe as part of https://reviews.llvm.org/D92004 or a pre-requisite thereof?).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99425/new/ https://reviews.llvm.org/D99425 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
