[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc83cd8feef7e: [NFC] Reordering parameters in getFile and getFileOrSTDIN (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/lib/Support/MemoryBuffer.cpp:275 + return getFileAux( + Filename, /*MapSize=*/-1, 0, /*IsText=*/false, + /*RequiresNullTerminator=*/false, IsVolati

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 333266. abhina.sreeskantharajan added a comment. Rebase and fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99182/new/ https://reviews.llvm.org/D99182 Files: clang/lib/Tooling/J

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. LGTM, with nit. Comment at: llvm/lib/Support/MemoryBuffer.cpp:275 + return getFileAux( + Filename, /*MapSize=*/-1, 0, /*IsText=*/false, + /*RequiresNullTer

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/include/llvm/Support/MemoryBuffer.h:78-80 /// if successful, otherwise returning null. If FileSize is specified, this /// means that the client knows th

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 332946. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. I've removed FileSize from getFileAux and WritableMemoryBuffer::getFile as well. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

jhenderson added a comment. Overall, this seems reasonable to me. I have a slight concern that it might cause surprising failures for downstream users, that aren't picked up at build time (due to implicit conversions), but I don't think you need to worry too much about that.

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 332720. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. After going through all the function usages, I realized FileSize is not used anywhere. I can remove this parameter. Repository: r

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 332644. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. Herald added a subscriber: JDevlieghere. Move FileSize to the end because it is never used. Repository: rG LLVM Github Monorepo C

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan created this revision. Herald added subscribers: dexonsmith, thopre, rupprecht, steven_wu, hiraditya, arichardson, emaste. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. abhina.sreeskantharajan requested review of this revision. Herald added projects