jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land.
LGTM, with nit. ================ Comment at: llvm/lib/Support/MemoryBuffer.cpp:275 + return getFileAux<WritableMemoryBuffer>( + Filename, /*MapSize=*/-1, 0, /*IsText=*/false, + /*RequiresNullTerminator=*/false, IsVolatile); ---------------- Whilst you're modifying, add the named parameter comment for the `0`, so that it's not just a magic number. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99182/new/ https://reviews.llvm.org/D99182 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
