This revision was automatically updated to reflect the committed changes.
Closed by commit rGf1a7d5a7b0ec: [-Wcalled-once-parameter] Harden analysis in
terms of block use (authored by vsavchenko).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98688/n
vsavchenko added inline comments.
Comment at: clang/test/SemaObjC/warn-called-once.m:861
// We consider captures by blocks as escapes
- [self indirect_call:(^{
+ [self indirect_call:(^{ // expected-note{{previous call is here}}
callback();
NoQ wro
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Great, thanks!!
Comment at: clang/test/SemaObjC/warn-called-once.m:861
// We consider captures by blocks as escapes
- [self indirect_call:(^{
+ [self indirect_call:(^{ // expe
vsavchenko updated this revision to Diff 331186.
vsavchenko added a comment.
Replace manual memory management of IPData with std::unique_ptr
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98688/new/
https://reviews.llvm.org/D98688
Files:
clang/in
vsavchenko added inline comments.
Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:1729
+ handleBlockThatIsGuaranteedToBeCalledOnce(const BlockDecl *Block) override {
+Data.flushWarnings(Block, S);
+ }
NoQ wrote:
> Do i understand correctly that you're
NoQ added inline comments.
Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:1729
+ handleBlockThatIsGuaranteedToBeCalledOnce(const BlockDecl *Block) override {
+Data.flushWarnings(Block, S);
+ }
Do i understand correctly that you're relying on the order
vsavchenko created this revision.
vsavchenko added a reviewer: NoQ.
Herald added a subscriber: Charusso.
vsavchenko requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch introduces a very simple inter-procedural analysis
between blocks
