NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Great, thanks!!
================
Comment at: clang/test/SemaObjC/warn-called-once.m:861
// We consider captures by blocks as escapes
- [self indirect_call:(^{
+ [self indirect_call:(^{ // expected-note{{previous call is here}}
callback();
----------------
What would it take to move this note to the `callback();` line? It would be
great to do so because blocks are often huge and `^` is often hard to notice.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98688/new/
https://reviews.llvm.org/D98688
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
