[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc1ee4fb5af49: [clang][AVR] Add avr-libc/include to clang system include paths (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

dylanmckay accepted this revision. dylanmckay added a comment. This revision is now accepted and ready to land. Looks good, nice and simple. Thanks @benshi001 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97669/new/ https://reviews.llvm.org/D97669 __

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a reviewer: efriedma. benshi001 added a subscriber: efriedma. benshi001 added a comment. @efriedma Could you please help me review this patch? It relates to the one you have reviewed for me, and is also about wrong mangled function name in c++ on AVR. The previous patch has corr

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. In D97669#2688771 , @Anastasia wrote: > In D97669#2687419 , @benshi001 wrote: > >> In D97669#2685698 , @Anastasia >> wrote: >> >>> In D97669#26784

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 updated this revision to Diff 337591. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97669/new/ https://reviews.llvm.org/D97669 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/basic_avr_tree/usr/lib/avr/include/.keep

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

Anastasia resigned from this revision. Anastasia added a comment. In D97669#2687419 , @benshi001 wrote: > In D97669#2685698 , @Anastasia wrote: > >> In D97669#2678460 , @bens

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. In D97669#2685698 , @Anastasia wrote: > In D97669#2678460 , @benshi001 wrote: > >> In D97669#2676826 , @Anastasia >> wrote: >> >>> In D97669#26658

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

Anastasia added a comment. In D97669#2678460 , @benshi001 wrote: > In D97669#2676826 , @Anastasia wrote: > >> In D97669#2665865 , @benshi001 >> wrote: >> >>> In D97669#26615

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. In D97669#2676826 , @Anastasia wrote: > In D97669#2665865 , @benshi001 wrote: > >> In D97669#2661560 , @Anastasia >> wrote: >> >>> Is `stdio.h` u

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

Anastasia added a comment. In D97669#2665865 , @benshi001 wrote: > In D97669#2661560 , @Anastasia wrote: > >> Is `stdio.h` used by anything? > > No. `stdio.h` is not used. But if I do `#include `, then `-I > /usr/

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 marked 2 inline comments as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

Anastasia added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const { benshi001 wrote: > Anasta

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const { Anastasia wrote: > benshi

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

Anastasia added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const { benshi001 wrote: > Anasta

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 marked an inline comment as done. benshi001 added a comment. In D97669#2661560 , @Anastasia wrote: > Is `stdio.h` used by anything? No. `stdio.h` is not used. But if I do `#include `, then `-I /usr/lib/avr/include` must be specified in the com

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

Anastasia added a comment. Is `stdio.h` used by anything? Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const { --

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. Although the bug can be avoided via "-I /usr/lib/avr/include" in clang's command line option, I expect clang to have the save behaviour as avr-gcc. And for avr-gcc, `avr-gcc a.c -mmcu=xxx` will automatically include avr-libc's header files and link avr-libc's lib.

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. This patch In D97669#2596073 , @aykevl wrote: > Looks reasonable to me. But again, I would like this to be reviewed also by > someone familiar with the internals of Clang (I'm not). Actually this patch is copied from msp430, w

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

aykevl added a comment. Looks reasonable to me. But again, I would like this to be reviewed also by someone familiar with the internals of Clang (I'm not). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97669/new/ https://reviews.llvm.org/D97669 _

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. Herald added a subscriber: ormris. The wrong `stdio.h` (usr/include/stdio.h) is included with a simple a.c like #include ... However the expected one is avr-libc's `stdio.h`, and this patch add avr-libc's include/ to clang system include paths. Repository: rG

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 created this revision. benshi001 added reviewers: dylanmckay, MaskRay, aykevl. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o