[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia added a comment. In D96771#2647848 , @gribozavr2 wrote: > Pushed the most minimal fix in > https://github.com/llvm/llvm-project/commit/41454c30f6a38c3e107d857e63da0561610fd141, > please double check. This looks great! Thanks for fixing this!

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

gribozavr2 added a comment. Pushed the most minimal fix in https://github.com/llvm/llvm-project/commit/41454c30f6a38c3e107d857e63da0561610fd141, please double check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96771/new/ https://reviews.llvm.or

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

gribozavr2 added a comment. Could you also update the switch statement in LLDB here: `llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:472` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96771/new/ https://reviews.llvm.org/D9

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1c8a151df83: [OpenCL] Added distinct file extension for C++ for OpenCL. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a p

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

svenvh accepted this revision. svenvh added a comment. LGTM; just one minor comment, which you can address as part of your commit. Comment at: clang/test/CodeGenOpenCLCXX/addrspace-with-class.clcpp:2 +// RUN: %clang_cc1 %s -triple spir-unknown-unknown -emit-llvm -O0 -o - | Fil

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia added a comment. Thanks, I have changed it to '.clcpp' and also replied in RFC: https://lists.llvm.org/pipermail/cfe-dev/2021-March/067936.html Let's wait a few days for some more feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96771/new/ https://reviews.llvm.org/D96

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia updated this revision to Diff 331317. Anastasia added a comment. Back to .clcpp! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96771/new/ https://reviews.llvm.org/D96771 Files: clang/include/clang/Basic/LangStandard.h clang/include/clang/Driver/Types.def clang/lib/Drive

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

awarzynski added a comment. In D96771#2628691 , @svenvh wrote: > In D96771#2626507 , @Anastasia wrote: > >> I had a second thought about the extension name and I realized that the >> reason why I initially wanted t

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

svenvh added a comment. In D96771#2626507 , @Anastasia wrote: > I had a second thought about the extension name and I realized that the > reason why I initially wanted to use `clcpp` is that it aligns better with > `clc++` which is used in `-cl-std`. Eve

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia added a comment. I had a second thought about the extension name and I realized that the reason why I initially wanted to use `clcpp` is that it aligns better with `clc++` which is used in `-cl-std`. Even though from the RFC the preference was towards `cppcl` it felt like there was no

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia updated this revision to Diff 330698. Anastasia added a comment. Updated Driver test to check -x option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96771/new/ https://reviews.llvm.org/D96771 Files: clang/include/clang/Basic/LangStandard.h clang/include/clang/Driver/Typ

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

awarzynski accepted this revision. awarzynski added a comment. Thank you for addressing my comments and for working on this! I've left one small suggestion, but that's a [nit]. Comment at: clang/test/Driver/cxx_for_opencl.cppcl:1 +// RUN: %clang %s -Xclang -verify -fsyntax-onl

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, but maybe give this another 24h before landing in case there are any remaining concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96771/new/ https://reviews.llvm.org/D9677

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia added a comment. In D96771#2574638 , @awarzynski wrote: > In D96771#2571855 , @Anastasia wrote: > >> This is only the initial patch and for the moment the primary goal is to >> remove the need for the fla

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia updated this revision to Diff 327915. Anastasia added a comment. Herald added subscribers: kbarton, nemanjai. - Renamed extensions to `cppcl` as it was more popular in RFC - Minimized number of changes in driver setup - Changed file extension in all C++ for OpenCL tests CHANGES SINCE L

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

awarzynski added a comment. In D96771#2571855 , @Anastasia wrote: > This is only the initial patch and for the moment the primary goal is to > remove the need for the flag at least from the clang perspective. Shorter compiler invocation is always nice! D

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia added a comment. In D96771#2571582 , @awarzynski wrote: > Hi @Anastasia , thank you for working on this! > > IIUC, this patch introduces: > > - new input types: `TY_CLCXX` and `TY_CLCXXHeader` > - new language: `OpenCLCXX` > > Based on the attach

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

awarzynski added a comment. Hi @Anastasia , thank you for working on this! IIUC, this patch introduces: - new input types: `TY_CLCXX` and `TY_CLCXXHeader` - new language: `OpenCLCXX` Based on the attached test, this is only to remove the need for `-cl-std=clc++`. Do you expect any other benefi

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia added inline comments. Comment at: clang/lib/Driver/Types.cpp:265 .Case("cl", TY_CL) + .Case("clcpp", TY_CLCXX) .Case("cp", TY_CXX) svenvh wrote: > mantognini wrote: > > I'm not sure we want that -- I'm actually fine if

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

svenvh added inline comments. Comment at: clang/lib/Driver/Types.cpp:265 .Case("cl", TY_CL) + .Case("clcpp", TY_CLCXX) .Case("cp", TY_CXX) mantognini wrote: > I'm not sure we want that -- I'm actually fine if we don't -- but I se

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

mantognini added a comment. I feel this would be a valuable addition, indeed. Only a minor question from me. Comment at: clang/lib/Driver/Types.cpp:265 .Case("cl", TY_CL) + .Case("clcpp", TY_CLCXX) .Case("cp", TY_CXX) I'm not s

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia created this revision. Anastasia added reviewers: svenvh, mantognini. Herald added subscribers: dexonsmith, ebevhan, yaxunl. Herald added a reviewer: jansvoboda11. Anastasia requested review of this revision. Files compiled with C++ for OpenCL can have a distinct file extension - `clcpp