awarzynski added a comment.

Hi @Anastasia , thank you for working on this!

IIUC, this patch introduces:

- new input types: `TY_CLCXX` and `TY_CLCXXHeader`
- new language: `OpenCLCXX`

Based on the attached test, this is only to remove the need for 
`-cl-std=clc++`. Do you expect any other benefits of introducing the above ^^^? 
And are you planning to to update the OpenCL C++ tests not to use  
`-cl-std=clc++`? Just trying to make sure I understand the reason behind this :)



================
Comment at: clang/lib/Driver/Types.cpp:163
 
-bool types::isOpenCL(ID Id) { return Id == TY_CL; }
+bool types::isOpenCL(ID Id) {
+  switch (Id) {
----------------
This is not used.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96771/new/

https://reviews.llvm.org/D96771

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to