This revision was automatically updated to reflect the committed changes.
Closed by commit rG1e8afba6f176: [clang] Add support for attribute
'swift_async_error' (authored by erik.pilkington).
Herald added a project: clang.
Changed prior to commit:
https://reviews.llvm.org/D96175?vs=322152&id=32
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM modulo some testing requests. Thanks!
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5977
+checkSwiftAsyncErrorBlock(S, D, ErrorAttr, AsyncAttr);
+}
+
---
erik.pilkington added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5977
+checkSwiftAsyncErrorBlock(S, D, ErrorAttr, AsyncAttr);
+}
+
aaron.ballman wrote:
> Should there be a diagnostic to combine `swift_error` and `swift_async_error`
> on the
erik.pilkington updated this revision to Diff 322152.
erik.pilkington marked 2 inline comments as done.
erik.pilkington added a comment.
Get rid of a useless `return`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96175/new/
https://reviews.llvm.org/D96175
Files:
clang/include/clang/
aaron.ballman added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5867
+ << AsyncAttr << isa(D);
+ return;
+}
You can elide this `return`.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5977
+checkSwiftAsyncErr
erik.pilkington created this revision.
erik.pilkington added reviewers: doug.gregor, aaron.ballman.
Herald added subscribers: jdoerfert, jkorous.
erik.pilkington requested review of this revision.
This attribute specifies how an error is represented for a swift async method.
rdar://71941280
htt
