[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

2021-02-04 Thread Zequan Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96fb49c3ff8e: [AST] Update LVal before evaluating lambda decl fields. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

2021-02-04 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10032-10033 + +// FIXME: Diagnostics here should point to the end of the initializer +// list, not the start. +if (!HandleLValueMember(Info, E, Subobject, Field, &Layout)) rsmi

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

2021-02-04 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 321617. zequanwu marked an inline comment as done. zequanwu added a comment. Remove comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96092/new/ https://reviews.llvm.org/D96092 Files: clang/lib/AST/Exp

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

2021-02-04 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ExprConstant.cpp:10032-10033 + +// FIXME: Diagnostics here should point to the end of the initializer +// list, not the start. +if (

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

2021-02-04 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu created this revision. zequanwu added reviewers: rsmith, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. PR48582 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96092 Files: clang/lib/AST/ExprCon