This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
DavidSpickett marked an inline comment as done.
Closed by commit rG1d51c699b9e2: [clang][Arm] Fix handling of -Wa,-march=
(authored by DavidSpickett).
Repository:
rG
nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.
Looks great. Thanks again David.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95872/new/
https://reviews.llvm.org/D95872
___
DavidSpickett marked 6 inline comments as done.
DavidSpickett added inline comments.
Comment at: clang/test/Driver/arm-target-as-march-mcpu.s:42
+/// We use the target CPU for both.
+// RUN: %clang -target arm-linux-gnueabi -### -c -mcpu=cortex-a8
-Wa,-march=armv8a %s 2>&1 | \
+
DavidSpickett updated this revision to Diff 321037.
DavidSpickett added a comment.
- Added split -Wa test for -mthumb
- Use `--check-prefix`/`--check-prefixes`
- Comment at top of march/mcpu file to explain choice of test CPUs
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ht
nickdesaulniers added inline comments.
Comment at: clang/test/Driver/arm-target-as-march-mcpu.s:42
+/// We use the target CPU for both.
+// RUN: %clang -target arm-linux-gnueabi -### -c -mcpu=cortex-a8
-Wa,-march=armv8a %s 2>&1 | \
+// RUN: FileCheck -check-prefix=TRIPLE-ARMV8 -
nickdesaulniers added a comment.
Wow, thank you so much for the work that went into this patch! Very thorough
tests. Just minor questions about yet more test cases. Patch LGTM.
Comment at: clang/test/Driver/arm-target-as-march-mcpu.s:42
+/// We use the target CPU for both.
+
DavidSpickett added reviewers: ostannard, nickdesaulniers.
DavidSpickett added inline comments.
Comment at: clang/lib/Driver/ToolChain.cpp:753
: tools::arm::getARMTargetCPU(MCPU, MArch, Triple);
StringRef Suffix =
tools::arm::getLLVMArchSuffixForARM(CPU,
DavidSpickett added a comment.
Bug link: https://bugs.llvm.org/show_bug.cgi?id=48894
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95872/new/
https://reviews.llvm.org/D95872
___
cfe-commits mailing list
DavidSpickett created this revision.
Herald added subscribers: danielkiss, kristof.beyls.
DavidSpickett requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This fixes Bugzilla #48894 for Arm, where it
was reported that -Wa,-march was not being
