nickdesaulniers added a comment. Wow, thank you so much for the work that went into this patch! Very thorough tests. Just minor questions about yet more test cases. Patch LGTM.
================ Comment at: clang/test/Driver/arm-target-as-march-mcpu.s:42 +/// We use the target CPU for both. +// RUN: %clang -target arm-linux-gnueabi -### -c -mcpu=cortex-a8 -Wa,-march=armv8a %s 2>&1 | \ +// RUN: FileCheck -check-prefix=TRIPLE-ARMV8 --check-prefix=CPU-A8 %s ---------------- Below you have a comment `(cortex-a32 is armv8a)`. That is very helpful for me. I assume `cortex-a8` is armv7a? ================ Comment at: clang/test/Driver/arm-target-as-march-mcpu.s:43 +// RUN: %clang -target arm-linux-gnueabi -### -c -mcpu=cortex-a8 -Wa,-march=armv8a %s 2>&1 | \ +// RUN: FileCheck -check-prefix=TRIPLE-ARMV8 --check-prefix=CPU-A8 %s +// RUN: %clang -target arm-linux-gnueabi -### -c -mcpu=cortex-a8 -Wa,-march=armv8-a \ ---------------- I guess `-check-prefix` is accepted with one or two leading hyphens. Let's pick one style to use consistently in this test. ================ Comment at: clang/test/Driver/arm-target-as-march-mcpu.s:82 +/// Last mcpu to compiler wins +// RUN: %clang -target arm-linux-gnueabi -### -c -mcpu=cortex-a32 -mcpu=cortex-a8 %s 2>&1 | \ +// RUN: FileCheck -check-prefix=TRIPLE-ARMV7 -check-prefix=CPU-A8 %s ---------------- add a `-mcpu=foo,bar` test for `-mcpu`? (Comma separated) ================ Comment at: clang/test/Driver/arm-target-as-march-mcpu.s:94 +/// Last march to compiler wins +// RUN: %clang -target arm-linux-gnueabi -### -c -march=armv8-a -march=armv7-a %s 2>&1 | \ +// RUN: FileCheck -check-prefix=TRIPLE-ARMV7 %s ---------------- add a comma separated test? (`-march=armv8-a,armv7-a`) ================ Comment at: clang/test/Driver/arm-target-as-mthumb.s:9-17 +// RUN: %clang -target armv7a-linux-gnueabi -### -c -Wa,-mcpu=cortex-a8,-mthumb \ +// RUN: %S/Inputs/wildcard1.c 2>&1 | FileCheck -check-prefix=TRIPLE-ARM %s // TRIPLE-ARM: "-triple" "armv7-unknown-linux-gnueabi" // RUN: %clang -target armv7a-linux-gnueabi -### -c -Wa,-mthumb %s 2>&1 | \ // RUN: FileCheck -check-prefix=TRIPLE-THUMB %s ---------------- Should we add space separated tests for these? `-Wa,-mcpu=cortex-a8 -Wa,-mthumb`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95872/new/ https://reviews.llvm.org/D95872 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
