[PATCH] D95204: [lld-macho] Switch default to new Darwin backend

2021-03-01 Thread Jez Ng via Phabricator via cfe-commits
int3 added a comment. I've reverted the clang driver changes for now in rG922de2574c17a755279358be928e5343dcf56c56 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95204/new/ htt

[PATCH] D95204: [lld-macho] Switch default to new Darwin backend

2021-03-01 Thread Jez Ng via Phabricator via cfe-commits
int3 added a comment. Thanks for the heads up. Looking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95204/new/ https://reviews.llvm.org/D95204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D95204: [lld-macho] Switch default to new Darwin backend

2021-03-01 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Hi, I suspect thispatch might be causing the failure we're seeing in our non-mac builders (https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-linux-x64/b8853941557626730880?): Testing: 0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..

[PATCH] D95204: [lld-macho] Switch default to new Darwin backend

2021-03-01 Thread Jez Ng via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG415c0cd698a8: [lld-macho] Switch default to new Darwin backend (authored by int3). Herald added a project: lld-macho. Changed prior to commit: htt

[PATCH] D95204: [lld-macho] Switch default to new Darwin backend

2021-03-01 Thread Jez Ng via Phabricator via cfe-commits
int3 updated this revision to Diff 327145. int3 added a comment. keep around darwinnew link for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95204/new/ https://reviews.llvm.org/D95204 Files: clang/lib/Driver/ToolChain.cpp clang/test/Drive

[PATCH] D95204: [lld-macho] Switch default to new Darwin backend

2021-02-08 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Comment at: lld/tools/lld/lld.cpp:74 .CasesLower("ld64", "ld64.lld", "darwin", Darwin) - .CasesLower("darwinnew", "ld64.lld.darwinnew", DarwinNew) .Default(Invalid); very nit: You could keep darwinnew around for a