This revision was automatically updated to reflect the committed changes.
Closed by commit rGd462aa5a619a: [clang] Fix a nullptr dereference bug on
invalid code (authored by adamcz).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95145/new/
https://r
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks.
Comment at: clang/test/SemaCXX/subst-func-type-invalid-ret-type.cpp:2
+// RUN: %clang -fsyntax-only -std=c++17 %s -Xclang -verify
+#include
+
adamcz
adamcz added a comment.
PTAL
Comment at: clang/test/SemaCXX/subst-func-type-invalid-ret-type.cpp:2
+// RUN: %clang -fsyntax-only -std=c++17 %s -Xclang -verify
+#include
+
adamcz wrote:
> hokein wrote:
> > A common practice is to avoid depending on STL in tests
adamcz updated this revision to Diff 318534.
adamcz added a comment.
addressed review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95145/new/
https://reviews.llvm.org/D95145
Files:
clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
clang
adamcz added inline comments.
Comment at: clang/test/SemaCXX/subst-func-type-invalid-ret-type.cpp:2
+// RUN: %clang -fsyntax-only -std=c++17 %s -Xclang -verify
+#include
+
hokein wrote:
> A common practice is to avoid depending on STL in tests. I think we need t
hokein added inline comments.
Comment at: clang/test/SemaCXX/subst-func-type-invalid-ret-type.cpp:2
+// RUN: %clang -fsyntax-only -std=c++17 %s -Xclang -verify
+#include
+
A common practice is to avoid depending on STL in tests. I think we need to
pull out (eve
adamcz created this revision.
adamcz added a reviewer: hokein.
adamcz requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
When working with invalid code, we would try to dereference a nullptr
while deducing template arguments in some dependend
