MaskRay added a comment.
In your commit the message does not include `Reviewed by:`. Many people agree
that both `Reviewed by:` & `Differential Revision:` should be present. The
`Reviewed by:` list indicates people who acknowledged the patch. (The
`Reviewers:` list does not necessarily mean all
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7b5d7c7b0a24: [hip] Fix `` compilation on
Windows with VS2019. (authored by hliao).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
hliao updated this revision to Diff 317966.
hliao added a comment.
Fix typo.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95075/new/
https://reviews.llvm.org/D95075
Files:
clang/lib/Headers/__clang_hip_cmath.h
Index: clang/lib/Headers/__clang
hliao created this revision.
hliao added reviewers: tra, yaxunl.
hliao requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D95075
Files:
clang/lib/Headers/__clang_hip_cmath.h
