[PATCH] D92386: [VE] Add standard include path and library path for C++

2020-12-09 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Thank you for suggestions. I'll submit patches to improve it. Comment at: clang/test/Driver/ve-toolchain.cpp:13 + +// RUN: %clangxx -### -target ve %s 2>&1 | FileCheck -check-prefix=DYNLINKER %s +// DYNLINKER: nld{{.*}} "-dynamic-linker" "/opt/nec/ve/lib/

[PATCH] D92386: [VE] Add standard include path and library path for C++

2020-12-09 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/Driver/ve-toolchain.cpp:13 + +// RUN: %clangxx -### -target ve %s 2>&1 | FileCheck -check-prefix=DYNLINKER %s +// DYNLINKER: nld{{.*}} "-dynamic-linker" "/opt/nec/ve/lib/ld-linux-ve.so.1" Many linker options t

[PATCH] D92386: [VE] Add standard include path and library path for C++

2020-12-03 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d30df7b5997: [VE] Add standard include path and library path for C++ (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D92386: [VE] Add standard include path and library path for C++

2020-12-03 Thread Simon Moll via Phabricator via cfe-commits
simoll accepted this revision. simoll added a comment. This revision is now accepted and ready to land. Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92386/new/ https://reviews.llvm.org/D92386 ___ c

[PATCH] D92386: [VE] Add standard include path and library path for C++

2020-12-03 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 updated this revision to Diff 309231. kaz7 added a comment. Add environment variable test as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92386/new/ https://reviews.llvm.org/D92386 Files: clang/lib/Driver/ToolChains/VEToolchain.

[PATCH] D92386: [VE] Add standard include path and library path for C++

2020-12-01 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 planned changes to this revision. kaz7 added inline comments. Comment at: clang/lib/Driver/ToolChains/VEToolchain.cpp:109 +return; + if (const char *cl_include_dir = getenv("NCC_CPLUS_INCLUDE_PATH")) { +SmallVector Dirs; simoll wrote: > Do we want a

[PATCH] D92386: [VE] Add standard include path and library path for C++

2020-12-01 Thread Simon Moll via Phabricator via cfe-commits
simoll added inline comments. Comment at: clang/lib/Driver/ToolChains/VEToolchain.cpp:109 +return; + if (const char *cl_include_dir = getenv("NCC_CPLUS_INCLUDE_PATH")) { +SmallVector Dirs; Do we want a test for this code path? Ie, checking system include

[PATCH] D92386: [VE] Add standard include path and library path for C++

2020-12-01 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: clang, VE. Herald added subscribers: cfe-commits, ormris. kaz7 requested review of this revision. We have a plan to add libcxx and libcxxabi for VE. In order to do so, we need to compile cxx source code wit