[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

leonardchan closed this revision. leonardchan added a comment. Ok this time I remembered the email. Unsure why the bug isn't automatically closed though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92141/new/ https://reviews.llvm.org/D92141 ___

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

thejh marked an inline comment as done. thejh added inline comments. Comment at: clang/test/Frontend/noderef.c:75-76 + // enclosing AddrOf. + p = &s->a;// ok + p = &(*s).a; // ok + p2 = &s->a; // expected-warning{{casting to dereferenceable pointer removes 'noderef' a

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

thejh updated this revision to Diff 307728. thejh added a comment. Removed duplicate tests as suggested by leonardchan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92141/new/ https://reviews.llvm.org/D92141 Files: clang/lib/Sema/SemaExprMember.

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Thanks Comment at: clang/test/Frontend/noderef.c:75-76 + // enclosing AddrOf. + p = &s->a;// ok + p = &(*s).a; // ok + p2 = &s->a; // expected-warn

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

thejh added a comment. (I marked this as depending on D92140 because if you apply this patch to the current HEAD directly, the tests will break.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92141/new/ https://re

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

thejh created this revision. thejh added reviewers: leonardchan, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. thejh requested review of this revision. As part of this change, one existing test case has to be adjusted because it accidentally stripped the NoD