leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land.
LGTM. Thanks ================ Comment at: clang/test/Frontend/noderef.c:75-76 + // enclosing AddrOf. + p = &s->a; // ok + p = &(*s).a; // ok + p2 = &s->a; // expected-warning{{casting to dereferenceable pointer removes 'noderef' attribute}} ---------------- These two can probably be removed since we have ``` p = &s->a; p = &(*s).b; ``` above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92141/new/ https://reviews.llvm.org/D92141 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits