This revision was automatically updated to reflect the committed changes.
Closed by commit rG3bd067272671: [MS] Fix double evaluation of MSVC builtin
arguments (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D92061?vs=307468&id=307674#toc
Repository:
rG LLVM Github Monor
rnk marked an inline comment as done.
rnk added a comment.
Thanks!
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1019
+ default:
+break;
+ case ARM::BI_BitScanForward:
thakis wrote:
> Maybe `return None` here and LLVM_UNREACHABLE at the bottom?
Sure, why no
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Nice!
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1019
+ default:
+break;
+ case ARM::BI_BitScanForward:
Maybe `return None` here and LLVM_UNREACHABLE
rnk created this revision.
rnk added reviewers: hans, thakis, rsmith, akhuang.
Herald added a subscriber: jfb.
Herald added a project: clang.
rnk requested review of this revision.
This code got quite twisted because we consider some MSVC builtins to be
target agnostic, and some to be target speci
