rnk marked an inline comment as done. rnk added a comment. Thanks!
================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1019 + default: + break; + case ARM::BI_BitScanForward: ---------------- thakis wrote: > Maybe `return None` here and LLVM_UNREACHABLE at the bottom? Sure, why not. Why do you like this version better? ================ Comment at: clang/lib/CodeGen/CodeGenFunction.h:4126 + llvm::Value *EmitEvaluatedMSVCBuiltin(MSVCIntrin BuiltinID, const CallExpr *E, + ArrayRef<llvm::Value *> Ops); ---------------- thakis wrote: > ...where's the definition of this function? I can't see calls either. I guess > this is a remnant from an earlier approach? Yeah, it is. I'll zap it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92061/new/ https://reviews.llvm.org/D92061 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
