rsmith added inline comments.
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:341
// Add the deployment target.
- if (Version[0] >= 520)
+ if (Version[0] >= 520 || LinkerIsLLDDarwinNew)
MachOTC.addPlatformVersionArgs(Args, CmdArgs);
Not a regression
thakis marked an inline comment as done.
thakis added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92037/new/
https://reviews.llvm.org/D92037
___
cfe-commits mailing list
cfe-commits@
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9a8386dba889: clang: Pass -platform-version to new MachO LLD
(authored by thakis).
Herald added a project: clang.
Changed prior to commit:
https://reviews.llvm.org/D92037?vs=307365&id=307369#toc
Reposi
hans accepted this revision.
hans added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Driver/ToolChain.h:334
/// LLD's supported flags, error output, etc.
- std::string GetLinkerPath(bool *LinkerIsLLD = nullptr) const;
+ //
thakis created this revision.
thakis added a reviewer: hans.
thakis requested review of this revision.
New MachO LLD doesn't implement the old -macos_version_min (etc)
flags, but it understands the modern platform_version flag.
So make the clang driver pass that when using new MachO LLD.
Also, wh
