rsmith added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:341
// Add the deployment target.
- if (Version[0] >= 520)
+ if (Version[0] >= 520 || LinkerIsLLDDarwinNew)
MachOTC.addPlatformVersionArgs(Args, CmdArgs);
----------------
Not a regression introduced by this change, but should this be
```
if ((Version[0] >= 520 && !LinkerIsLLD) || LinkerIsLLDDarwinNew)
```
? `ld64.lld` doesn't appear to understand `-platform_version`, and linking with
`clang -fuse-ld=lld` on MacOS 10.15.7 seems to fail for this reason.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92037/new/
https://reviews.llvm.org/D92037
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
