[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72badbcdccd1: [NPM] Move more O0 pass building into PassBuilder (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91585/new/ https://reviews.llvm.org/D91585 ___

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

aeubanks updated this revision to Diff 306473. aeubanks added a comment. change strings to check for Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91585/new/ https://reviews.llvm.org/D91585 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

tejohnson added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:2365 +Matches[1] != "lto") { + MPM.addPass(buildO0DefaultPipeline(L, Matches[1] != "default")); return Error::success(); tejohnson wrote: > I think it would be cleare

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:2365 + // Don't do anything for (thin)lto backend compiles at O0. + if (Matches[1] != "thinlto" && Matches[1] != "lto") +MPM.addPass(buildO0Def

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

aeubanks updated this revision to Diff 306448. aeubanks added a comment. check 'thinlto-pre-link'/'lto-pre-link' explicitly add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91585/new/ https://reviews.llvm.org/D91585 Files: clang/lib/CodeGe

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

tejohnson added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:2365 +Matches[1] != "lto") { + MPM.addPass(buildO0DefaultPipeline(L, Matches[1] != "default")); return Error::success(); I think it would be clearer to check against

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

aeubanks updated this revision to Diff 305900. aeubanks added a comment. make build(Thin)LTODefaultPipeline handle O0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91585/new/ https://reviews.llvm.org/D91585 Files: clang/lib/CodeGen/BackendUtil.c

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

aeubanks planned changes to this revision. aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:2365 + // Don't do anything for (thin)lto backend compiles at O0. + if (Matches[1] != "thinlto" && Matches[1] != "lto") +MPM.addPass(buildO0Def

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:2365 + // Don't do anything for (thin)lto backend compiles at O0. + if (Matches[1] != "thinlto" && Matches[1] != "lto") +MPM.addPass(buildO0DefaultPipeline(L, Matches[1] != "default"));

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

tejohnson added a comment. Thanks, generally this seems to be good cleanup. Question on one of the changes below though. Comment at: llvm/lib/Passes/PassBuilder.cpp:2365 + // Don't do anything for (thin)lto backend compiles at O0. + if (Matches[1] != "thinlto" && Mat

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

aeubanks created this revision. aeubanks added reviewers: ychen, asbirlea, tejohnson. Herald added subscribers: llvm-commits, cfe-commits, wenlei, lxfind, steven_wu, modocache, JDevlieghere, hiraditya. Herald added projects: clang, LLVM. aeubanks requested review of this revision. This moves hand