tejohnson added inline comments.
================
Comment at: llvm/lib/Passes/PassBuilder.cpp:2365
+ Matches[1] != "lto") {
+ MPM.addPass(buildO0DefaultPipeline(L, Matches[1] != "default"));
return Error::success();
----------------
tejohnson wrote:
> I think it would be clearer to check against "thinlto-pre-link" and
> "lto-pre-link" here (and more robust in case any other types added in the
> future).
Sorry, to be more explicit, I was talking about the below line, where it sets
up the LTOPreLink parameter to buildO0DefaultPipeline. I think the above line
is actually better the way it was (checking != "thinlto" and != "lto").
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91585/new/
https://reviews.llvm.org/D91585
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
