This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1bbf87e22a73: [clangd][remote] Check an index file correctly
(authored by ArcsinX).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ArcsinX updated this revision to Diff 303766.
ArcsinX added a comment.
Do not use unique pointer for Index
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91049/new/
https://reviews.llvm.org/D91049
Files:
clang-tools-extra/clangd/index/remote/serv
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:365
}
+ auto Index = std::make_unique(std::move(SymIndex));
well actually w
ArcsinX created this revision.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman.
Herald added a project: clang.
ArcsinX requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
There is not reason to check `std::make_unique<...>(..)` return value,
bu
