fpetrogalli updated this revision to Diff 303908.
fpetrogalli marked an inline comment as done.
fpetrogalli added a comment.
I removed the enablement of __ARM_FEATURE_SVE_PREDICATE_OPERATORS as the
codegen is incorrect.
I have extended testing of the codegen for __ARM_FEATURE_SVE_VECTOR_OPERATOR
peterwaller-arm added a comment.
Suggestion: Where referencing sections you could include the title "3.7.3.3.
Behavior specific to SVE vectors" instead of "3.7.3.3" for example. I think
this makes it easier to spot misreferences and gives future souls a better
chance to understand the context w
peterwaller-arm added inline comments.
Comment at:
clang/test/CodeGen/aarch64-sve-acle-__ARM_FEATURE_SVE_VECTOR_OPERATORS-expected-error-on-address.c:6
+
+// Examples taken from section 3.7.3.3 of the SVE ACLE (Version
+// 00bet6) that can be found at
Reposit
fpetrogalli updated this revision to Diff 303805.
fpetrogalli added a comment.
NFC: update tests to use `%clang_cc1` instead of `%clang` to prevent errors for
missing includes: https://reviews.llvm.org/B77907
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llv
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
Simple and straightforward, with documentation! :)
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90956/new/
https://reviews.l
fpetrogalli created this revision.
fpetrogalli added reviewers: peterwaller-arm, paulwalker-arm, efriedma,
c-rhodes.
Herald added subscribers: cfe-commits, psnobl, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added a project: clang.
fpetrogalli requested review of this revisi