[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

thakis added a comment. My bots look happy at least. Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https://reviews.llvm.org/D90568 ___ cfe-commits mailing list cfe-co

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 added a comment. In D90568#3949134 , @thakis wrote: > This breaks the build: http://45.33.8.238/linux/92294/step_4.txt > > Please take a look and revert for now if it takes a while to fix. Apologies it took 2 times, It should all be good now, lmk

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

thakis added a comment. This breaks the build: http://45.33.8.238/linux/92294/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https://reviews.llvm.org/D90568 __

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG15e76eed0c76: [clang] Add [is|set]Nested methods to NamespaceDecl (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D90568

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 updated this revision to Diff 477467. njames93 added a comment. Hopefully fixed line endings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https://reviews.llvm.org/D90568 Files: clang/include/clang/AST/Decl.h clang/include/

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Decl.h:546 + + enum Flags : unsigned { F_Inline = 1 << 0, F_Nested = 1 << 1 }; + njames93 wrote: > aaron.ballman wrote: > > I'm not really loving the `F_` prefixes -- the enumerators are al

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 added inline comments. Comment at: clang/test/AST/ast-dump-decl.cpp:1 -// Test without serialization: -// RUN: %clang_cc1 -std=c++11 -triple x86_64-linux-gnu -fms-extensions \ -// RUN: -ast-dump -ast-dump-filter Test %s \ -// RUN: | FileCheck --strict-whitespace %s -// -

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 added inline comments. Comment at: clang/include/clang/AST/Decl.h:546 + + enum Flags : unsigned { F_Inline = 1 << 0, F_Nested = 1 << 1 }; + aaron.ballman wrote: > I'm not really loving the `F_` prefixes -- the enumerators are already > privately scoped

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

shafik added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8767-8770 const_cast(*Context), Context->getTranslationUnitDecl(), /*Inline*/ false, SourceLocation(), SourceLocation(), &Context->Idents.get("std"), +/*PrevDecl*/ nullptr, /

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Generally LGTM, though I found a few minor things. Comment at: clang/include/clang/AST/Decl.h:546 + + enum Flags : unsigned { F_Inline = 1 << 0, F_Nested = 1 <

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https://reviews.llvm.org/D90568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https://reviews.llvm.org/D90568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

Mordante added a comment. In D90568#2370079 , @njames93 wrote: > Added JsonNodeDumper and argument comments. Thanks, I've no further comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 updated this revision to Diff 302437. njames93 added a comment. Added JsonNodeDumper and argument comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https://reviews.llvm.org/D90568 Files: clang/include/clang/AST/Decl.h

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

shafik added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:7866 SourceLocation(), &Context->Idents.get("std"), - /*PrevDecl*/ nullptr); + /*PrevDecl*/ nullptr, false); NS-

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

Mordante added a comment. Just a few minor nits. I'll leave the approving to the other reviewers. Comment at: clang/lib/AST/TextNodeDumper.cpp:1828 + if (D->isNested()) +OS << " nested"; if (!D->isOriginalNamespace()) Can you also modify `JSONNodeDumper

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 created this revision. njames93 added a reviewer: rsmith. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: shafik. Herald added a project: clang. njames93 requested review of this revision. Adds support for NamespaceDecl to inform if its part of a nested namespace.