njames93 added inline comments.
================ Comment at: clang/include/clang/AST/Decl.h:546 + + enum Flags : unsigned { F_Inline = 1 << 0, F_Nested = 1 << 1 }; + ---------------- aaron.ballman wrote: > I'm not really loving the `F_` prefixes -- the enumerators are already > privately scoped to `NamespaceDecl`, is that not sufficient protection? I think just having it named as Inline and Nested is going to confuse things even more, `BlockDecl` seems to use `flag_is<FLAG>` for its packing, and I think that is even worse. WDYT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https://reviews.llvm.org/D90568 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits