This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
sammccall marked 4 inline comments as done.
Closed by commit rG55120f74ca12: [Syntax] Add minimal TableGen for syntax
nodes. NFC (authored by sammccall).
Changed prior
hokein accepted this revision.
hokein added inline comments.
Comment at: clang/utils/TableGen/ClangSyntaxEmitter.cpp:107
+llvm::raw_ostream &OS) {
+ OS << "// Generated from " << Records.getInputFilename() << "\n";
+ OS << R"cpp(
gribozavr2 added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Syntax.td:31
+
+// NodeType is the root of the archetype hierarchy.
+class NodeType {
"Records derived from NodeType correspond to syntax tree node types."
Repository:
rG LLVM Gi
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Tooling/Syntax/Syntax.td:9
+//
+// The C++ grammatical structure modeled by libSyntax is quite regular.
+//
==
sammccall added inline comments.
Comment at: clang/lib/Tooling/Syntax/Tree.cpp:389
case NodeKind::ParameterDeclarationList:
+ case NodeKind::DeclaratorList:
return clang::tok::comma;
OK, this is not *quite* NFC:
- before this patch, `List::classof(Decla
sammccall created this revision.
sammccall added reviewers: eduucaldas, gribozavr, hokein.
Herald added subscribers: cfe-commits, mgrang, mgorny.
Herald added a project: clang.
sammccall requested review of this revision.
So far, only used to generate Kind and implement classof().
My plan is to h
