hokein accepted this revision.
hokein added inline comments.

================
Comment at: clang/utils/TableGen/ClangSyntaxEmitter.cpp:107
+                                    llvm::raw_ostream &OS) {
+  OS << "// Generated from " << Records.getInputFilename() << "\n";
+  OS << R"cpp(
----------------
By looking at the existing tablegen patterns, I think we should invoke 
`emitSourceFileHeader` to emit the head file comments for the generated `.inc` 
file. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90540/new/

https://reviews.llvm.org/D90540

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to