[PATCH] D90291: [clangd] Add lit tests for remote index

2020-11-02 Thread Hans Wennborg via Phabricator via cfe-commits
hans added inline comments. Comment at: clang-tools-extra/clangd/test/lit.site.cfg.py.in:11 config.host_triple = "@LLVM_HOST_TRIPLE@" +config.python_executable = "@Python3_EXECUTABLE@" kadircet wrote: > hans wrote: > > Could this use `PYTHON_EXECUTABLE` instea

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-11-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/lit.site.cfg.py.in:11 config.host_triple = "@LLVM_HOST_TRIPLE@" +config.python_executable = "@Python3_EXECUTABLE@" hans wrote: > Could this use `PYTHON_EXECUTABLE` instead? I see other t

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-11-02 Thread Hans Wennborg via Phabricator via cfe-commits
hans added inline comments. Comment at: clang-tools-extra/clangd/test/lit.site.cfg.py.in:11 config.host_triple = "@LLVM_HOST_TRIPLE@" +config.python_executable = "@Python3_EXECUTABLE@" Could this use `PYTHON_EXECUTABLE` instead? I see other tests using that, a

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-11-01 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:42 + found_init_message = False + for line in index_server_process.stderr: +if b'Server listening' in line: so if we think `.readline()` is blocking bu

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-11-01 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:51 + clangd_process.wait() + os.kill(index_server_process.pid, 9) + kadircet wrote: > can we rather use `signal.SIGXXX` here instead of `9` ? > > Also rat

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-11-01 Thread Kirill Bobyrev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76a168bce01d: [clangd] Add lit tests for remote index (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-11-01 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:36 + ], + stderr=subprocess.PIPE) + kadircet wrote: > nit: formatting looks off, is this really what yapf offers? Y

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-11-01 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 302213. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Resolve post-LGTM commentts, increase index hot reload frequency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://r

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-10-30 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/test/lit.cfg.py:26 config.clangd_binary_dir + "/benchmarks")) +config.substitutions.appen

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-10-29 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 301619. kbobyrev marked an inline comment as done. kbobyrev added a comment. Rebase on top of master, don't force forward slashes in project root, format Python helper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-10-29 Thread Aleksandr Platonov via Phabricator via cfe-commits
ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline.test:3 +# RUN: clangd-indexer %S/Inputs/Source.cpp > %t.idx +# RUN: %python %S/pipeline_helper.py --input-file-name=%s --project-root=%/S --index-file=%t.idx | FileCheck %s +# REQUIRES

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-10-29 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline.test:3 +# RUN: clangd-indexer %/S/../Inputs/remote-index/Source.cpp > %t.in.dex +# RUN: python %/S/pipeline_helper.py --input-file-name=%s --server-address=0.0.0.0:50051 --test-direct

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-10-29 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 301607. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/D90291 Files: clang-tools-extra/clangd/test/CMakeLists.txt clan

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-10-29 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 301606. kbobyrev marked 8 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/D90291 Files: clang-to

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-10-29 Thread Aleksandr Platonov via Phabricator via cfe-commits
ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline.test:3 +# RUN: clangd-indexer %/S/../Inputs/remote-index/Source.cpp > %t.in.dex +# RUN: python %/S/pipeline_helper.py --input-file-name=%s --server-address=0.0.0.0:50051 --test-directo

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-10-29 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline.test:1 +# RUN: rm -rf %/t +# RUN: clangd-indexer %/S/../Inputs/remote-index/Source.cpp > %t.in.dex nit: `/` shouldn't be needed here. the difference between %t and %/

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-10-28 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 301303. kbobyrev added a comment. Don't change the existing Python formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/D90291 Files: clang-tools-extra/clangd/test/C

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-10-28 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 301298. kbobyrev added a comment. Push the Franken-pytest. Benefits: doesn't fail, is platform independent (to be determined). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-10-28 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 301268. kbobyrev added a comment. Fix test except shutting down part :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/D90291 Files: clang-tools-extra/clangd/test/CMakeLis

[PATCH] D90291: [clangd] Add lit tests for remote index

2020-10-28 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorep