kadircet added inline comments.
================ Comment at: clang-tools-extra/clangd/test/lit.site.cfg.py.in:11 config.host_triple = "@LLVM_HOST_TRIPLE@" +config.python_executable = "@Python3_EXECUTABLE@" ---------------- hans wrote: > Could this use `PYTHON_EXECUTABLE` instead? I see other tests using that, and > Python3_EXECUTABLE might not always be set. i was checking llvm's [lit.site.cfg.py.in](http://github.com//llvm/llvm-project/tree/master/llvm/test/lit.site.cfg.py.in) for reference and it was using python3 too. any specific reasons for using PYTHON_EXECUTABLE instead of python3? I can't say this was a strong preference, but the python script included might not be python2 compliant, hence the need for 3. If there is a compelling reason for using a possibly python2 executable, we can try to make the script both 2 and 3 compliant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/D90291 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
