This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc8f84bd0947d: [Clang][CodeGen] fix failed assertion
(authored by nickdesaulniers).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
Please make sure the commit message is significantly more descriptive here than
what is on the review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
nickdesaulniers updated this revision to Diff 300733.
nickdesaulniers added a comment.
- dyn_cast, else
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90073/new/
https://reviews.llvm.org/D90073
Files:
clang/lib/CodeGen/CodeGenModule.cpp
clang/t
aaron.ballman added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4640
/*D=*/nullptr);
-LT = getLLVMLinkageVarDefinition(cast(GD.getDecl()),
- D->getType().isConstQualified());
+if
erichkeane added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4643
+ D->getType().isConstQualified());
+else if (isa(GD.getDecl()))
+ LT = getFunctionLinkage(GD);
I'd suggest making this just 'els
nickdesaulniers created this revision.
nickdesaulniers added reviewers: aaron.ballman, iajbar.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
nickdesaulniers requested review of this revision.
Via bugreport:
https://reviews.llvm.org/D66492#2350947
Repository:
rG LLVM Gi
