[PATCH] D89849: Add option 'exceptions' to pragma clang fp

2020-10-31 Thread Serge Pavlov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6021cbea4d34: Add option 'exceptions' to pragma clang fp (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D89849?vs=2998

[PATCH] D89849: Add option 'exceptions' to pragma clang fp

2020-10-22 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:3041 + if (AnnotValue->ExceptionsValue) +Actions.setExceptionMode(Tok.getLocation(), *AnnotValue->ExceptionsValue); ConsumeAnnotationToken(); mibintc wrote: > sepavloff wrote: >

[PATCH] D89849: Add option 'exceptions' to pragma clang fp

2020-10-22 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 299887. sepavloff added a comment. Added ActOnPragmaFPExceptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89849/new/ https://reviews.llvm.org/D89849 Files: clang/docs/LanguageExtensions.rst clang/in

[PATCH] D89849: Add option 'exceptions' to pragma clang fp

2020-10-21 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:3041 + if (AnnotValue->ExceptionsValue) +Actions.setExceptionMode(Tok.getLocation(), *AnnotValue->ExceptionsValue); ConsumeAnnotationToken(); sepavloff wrote: > mibintc wrote: > >

[PATCH] D89849: Add option 'exceptions' to pragma clang fp

2020-10-21 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3223 +// Preserve floating point exceptions +#pragma fp exceptions(strict) +z = x + y; mibintc wrote: > do you mean pragma clang fp ... Sure. Thank you!

[PATCH] D89849: Add option 'exceptions' to pragma clang fp

2020-10-21 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3223 +// Preserve floating point exceptions +#pragma fp exceptions(strict) +z = x + y; do you mean pragma clang fp ... Comment at: clang/lib/Parse/ParsePr

[PATCH] D89849: Add option 'exceptions' to pragma clang fp

2020-10-20 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, mibintc, kpn. Herald added a subscriber: dexonsmith. Herald added a project: clang. sepavloff requested review of this revision. Pragma 'clang fp' is extended to support a new option, 'exceptions'. It allows to specify f