sepavloff added inline comments.
================ Comment at: clang/lib/Parse/ParsePragma.cpp:3041 + if (AnnotValue->ExceptionsValue) + Actions.setExceptionMode(Tok.getLocation(), *AnnotValue->ExceptionsValue); ConsumeAnnotationToken(); ---------------- mibintc wrote: > sepavloff wrote: > > mibintc wrote: > > > Did you consider adding ActOnPragmaFPExceptions? > > The existing method `setExceptionMode` does everything that we need. Do you > > think it should be renamed to `ActOnPragmaFPExceptions`? Are there any > > advantages for this? > I think it's easier to understand if it's written to parallel the other 2 fp > pragmas that have similar semantics (contract and reassociate). It makes sense. This is a parser semantic action, they usually have names `ActOn...`. I didn't rename `setExceptionMode `, as in future we might need to set exception behavior from a place other than Parser. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89849/new/ https://reviews.llvm.org/D89849 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
