[PATCH] D89514: clangd: Stop calling FileEntryRef::FileEntryRef

2020-10-23 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith marked an inline comment as done. dexonsmith added a comment. Committed in 434f3774f629f5896614e9efb4eda82d813402ed . Comment at: clang-tools-extra/clangd/ParsedAST.cpp:222 if (File)

[PATCH] D89514: clangd: Stop calling FileEntryRef::FileEntryRef

2020-10-23 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM with a nit. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:222 if (File) // FIXME: Use correctly named FileEntryRef. +Delegate->FileSkipp

[PATCH] D89514: clangd: Stop calling FileEntryRef::FileEntryRef

2020-10-15 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added subscribers: usaxena95, ributzka, kadircet. dexonsmith requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. In `ReplayPreamble::replay`, use `getFileRef` instead of `getFile`, and