[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski added a comment. In D88381#2357123 , @sameeranjoshi wrote: > I would wait for a couple of more days for someone to review from community > may be from Nvidia's side if someone would verify the initial design. As there were no new reviews, I a

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd28de0d7f257: [Flang][Driver] Add PrintPreprocessedInput FrontendAction (`flang-new -E`) (authored by CarolineConcatto, committed by awarzynski). C

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski updated this revision to Diff 301066. awarzynski added a comment. Rebase on top of master + rename accessor method Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88381/new/ https://reviews.llvm.org/D88381 Files: clang/include/clang/Dri

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

sameeranjoshi added a comment. Looks good, I would wait for a couple of more days for someone to review from community may be from Nvidia's side if someone would verify the initial design. Thank you. Comment at: flang/include/flang/Frontend/CompilerInvocation.h:12 #include "f

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski added inline comments. Comment at: flang/include/flang/Frontend/CompilerInvocation.h:12 #include "flang/Frontend/FrontendOptions.h" +#include "flang/Parser/parsing.h" #include "clang/Basic/Diagnostic.h" sameeranjoshi wrote: > awarzynski wrote: > > sa

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

sameeranjoshi added a comment. A few `nits:` and mostly style comments inline: Comment at: flang/include/flang/Frontend/CompilerInvocation.h:12 #include "flang/Frontend/FrontendOptions.h" +#include "flang/Parser/parsing.h" #include "clang/Basic/Diagnostic.h"

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski updated this revision to Diff 299100. awarzynski added a comment. Apply fix to unit test that got lost in the previous patch, simplify C input file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88381/new/ https://reviews.llvm.org/D88381

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski added inline comments. Comment at: flang/include/flang/Frontend/CompilerInstance.h:85 + /// Return parsing to be used by Actions. + Fortran::parser::Parsing &GetParsing() const { return *parsing_; } + sameeranjoshi wrote: > If I am correct this seems

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski updated this revision to Diff 299092. awarzynski marked 3 inline comments as done. awarzynski added a comment. Address PR comments, make clearer separation between option types, simplify/fix tests Based on the feedback, I've made a clearer separation between the parser and the fronten

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

sameeranjoshi added a comment. Thank you, this patch looks easy to understand as it's clearly separated from(`D87989`) the infrastructure changes needed for frontend actions. A few comments inline. Comment at: flang/include/flang/Frontend/CompilerInstance.h:85 + /// Return pa