sameeranjoshi added a comment. A few `nits:` and mostly style comments inline:
================ Comment at: flang/include/flang/Frontend/CompilerInvocation.h:12 #include "flang/Frontend/FrontendOptions.h" +#include "flang/Parser/parsing.h" #include "clang/Basic/Diagnostic.h" ---------------- awarzynski wrote: > sameeranjoshi wrote: > > `Nit:` I believe `clang-format` is missing. > I did apply it and this line looks OK to me - what's missing? See point 2[1] below the code block. Ideally clang comes alphabetically first. [1] https://github.com/llvm/llvm-project/blob/master/flang/docs/C++style.md#files ================ Comment at: flang/include/flang/Frontend/FrontendActions.h:9 #ifndef LLVM_FLANG_FRONTEND_FRONTENDACTIONS_H #define LLVM_FLANG_FRONTEND_FRONTENDACTIONS_H ---------------- Why is this not following the style guide mentioned at [1] point 2. [1] https://github.com/llvm/llvm-project/blob/master/flang/docs/C++style.md#files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88381/new/ https://reviews.llvm.org/D88381 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
