[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry added a comment. In D87587#2602523 , @HazardyKnusperkeks wrote: > In D87587#2597241 , @kuzkry wrote: > >> Thank you for delivering it, @HazardyKnusperkeks. >> >> One thing concerns me though. I'm not an auth

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks added a comment. In D87587#2597241 , @kuzkry wrote: > Thank you for delivering it, @HazardyKnusperkeks. > > One thing concerns me though. I'm not an author of changes done in > clang/docs/ClangFormatStyleOptions.rst in lines 2372, 3069-

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry added a comment. Thank you for delivering it, @HazardyKnusperkeks. One thing concerns me though. I'm not an author of changes done in clang/docs/ClangFormatStyleOptions.rst in lines 2372, 3069-3073, 3075, 3077, 3082-3086, 3088, 3093-3097, 3099, 3104-3108, and 3110-3111. Perhaps it's just

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG6ca52815fb3c: [clang-format][PR47290] Add ShortNamespaceLines format option (authored by kuzkry, committed by HazardyKnus

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry added a comment. In D87587#2592722 , @HazardyKnusperkeks wrote: > In D87587#2592605 , @kuzkry wrote: > >>> Do you need someone to push it? >> >> Yes, I need someone to do that. I don't have write permissions

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks added a comment. In D87587#2592605 , @kuzkry wrote: >> Do you need someone to push it? > > Yes, I need someone to do that. I don't have write permissions. I'm new here. Please state the name and mail for the commit. I will push it for y

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/ https://reviews.llvm.org/D87587 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry added a comment. > Do you need someone to push it? Yes, I need someone to do that. I don't have write permissions. I'm new here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/ https://reviews.llvm.org/D87587 _

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks added a comment. Is this acceptable to the others? Do you need someone to push it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/ https://reviews.llvm.org/D87587 ___ cfe-comm

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Although I would put it in one test, this is fine by me. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:1201-1206 +} + +TEST_F(ShortNamespaceLinesTest, + MultipleUnwrapped

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry marked 2 inline comments as done. kuzkry added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:1162 + + EXPECT_EQ(DefaultUnwrappedLines, Style.ShortNamespaceLines); + EXPECT_EQ("namespace ShortNamespace {\n" curdeius

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry updated this revision to Diff 323289. kuzkry marked 2 inline comments as done. kuzkry added a comment. Rebased to the tip of the main branch, merged similar tests (requested by @curdeius) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/n

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

curdeius added a comment. Almost there. I hope I'm clear this time on what I'd like to see. Thanks for the release notes update. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:1162 + + EXPECT_EQ(DefaultUnwrappedLines, Style.ShortNamespaceLines); + EXPECT

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry marked 3 inline comments as done. kuzkry added a comment. In D87587#2552314 , @curdeius wrote: > Please regroup tests and add release notes. Regroup tests - by that I think you meant all your 4 remarks about the tests. So I've done 3/4 :D Release

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry marked 3 inline comments as done. kuzkry added a comment. In D87587#2552232 , @HazardyKnusperkeks wrote: > Apart from my comments, this looks good to me and I really wonder why it > hasn't been pushed. (I would directly use it!) I don't know, may

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry updated this revision to Diff 322880. kuzkry added a comment. Sorted code alphabetically as suggested by @HazardyKnusperkeks and applied almost all fixes proposed by @curdeius (entry in release notes + some changes in unit tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Please regroup tests and add release notes. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:1126 + + EXPECT_EQ(UnwrappedLines, Style.Short

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks added a comment. Apart from my comments, this looks good to me and I really wonder why it hasn't been pushed. (I would directly use it!) Comment at: clang/include/clang/Format/Format.h:2821 MaxEmptyLinesToKeep == R.MaxEmptyLinesToKeep && +

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry updated this revision to Diff 313218. kuzkry retitled this revision from "[clang-format][PR47290] Add MaxUnwrappedLinesForShortNamespace format option" to "[clang-format][PR47290] Add ShortNamespaceLines format option". kuzkry added a comment. Renamed MaxUnwrappedLinesForShortNamespace to