lalovic added a comment.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86707/new/
https://reviews.llvm.org/D86707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3e1e5f54492d: [SystemZ][z/OS] Adding initial toolchain for
z/OS (authored by abhina.sreeskantharajan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86707/ne
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
Confirming LGTM. @abhina.sreeskantharajan, it seems that you have a good number
of commits to the project (I see at least three). If you do not yet have commit
access, it may be appropriate to request it now s
abhina.sreeskantharajan updated this revision to Diff 289148.
abhina.sreeskantharajan marked an inline comment as done.
abhina.sreeskantharajan added a comment.
Thanks Hubert, I removed the lines.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86707/
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.
LGTM with minor comments.
Comment at: clang/lib/Driver/ToolChains/ZOS.cpp:15
+
+using namespace clang::driver;
+using namespace clang::driver:
abhina.sreeskantharajan marked an inline comment as done.
abhina.sreeskantharajan added inline comments.
Comment at: clang/lib/Driver/ToolChains/ZOS.h:25
+
+ bool isPICDefault() const override { return false; }
+ bool isPIEDefault() const override { return false; }
hubert.reinterpretcast added inline comments.
Comment at: clang/lib/Driver/ToolChains/ZOS.h:25
+
+ bool isPICDefault() const override { return false; }
+ bool isPIEDefault() const override { return false; }
According to the RFC re: LLVM on z/OS, the initial sup
abhina.sreeskantharajan created this revision.
abhina.sreeskantharajan added reviewers: Kai, uweigand, hubert.reinterpretcast,
stevewan, SeanP, lalovic.
Herald added subscribers: cfe-commits, mgorny.
Herald added a project: clang.
abhina.sreeskantharajan requested review of this revision.
This pa
