This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG53c593c2c893: [clang] Make signature help work with
dependent args (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
kadircet added inline comments.
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5513
for (OverloadCandidate &Candidate : CandidateSet) {
-if (Candidate.Function && Candidate.Function->isDeleted())
- continue;
+if (Candidate.Function) {
+ if (Candidate.Functio
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
thanks, looks better.
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5513
for (OverloadCandidate &Candidate : CandidateSet) {
-if (Candidate.Function && Candidate.Fun
kadircet updated this revision to Diff 285141.
kadircet added a comment.
- Change logic to find all signatures without any dependent args and post
filter non-viable overloads using the argument counts.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
kadircet added inline comments.
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5573
+ // performing any semantic checks on availability. That's to improve user
+ // experience, it is better to see all overloads rather than none.
+ if (Expr::hasAnyTypeDependentArguments(Args))
kadircet updated this revision to Diff 285117.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Fix typo in comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85826/new/
https://reviews.llvm.org/D85826
Files:
clang-tools
kadircet updated this revision to Diff 285116.
kadircet added a comment.
- Add tests into clang-lit
- Make sure current number of args is less than overloads param count.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85826/new/
https://reviews.llvm
hokein added a comment.
This looks like a nice improvement.
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1212
+ R"cpp(
+int foo(int a, int b);
+template void bar(T t) {
These tests are nice.
But we're changing Sema
kadircet created this revision.
kadircet added a reviewer: hokein.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous.
Herald added a project: clang.
kadircet requested review of this revision.
Herald added a subscriber: ilya-biryukov.
Fixes https://github.com/clangd/clangd/issues
