[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

asbirlea added a comment. Done in https://reviews.llvm.org/rG7ea0ee30588, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84713/new/ https://reviews.llvm.org/D84713 ___ cfe-commits mailing list cfe-commits

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

nikic added a comment. The regression here seems to be because operations on an empty GraphDiff don't optimize out. Not going through GraphDiff but using the same basic logic (https://github.com/llvm/llvm-project/commit/4c6a5de8131183ff88f52cc3dda67180e31501a1 -- going through a separate method

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

asbirlea added a comment. I'm looking into it. If needed this can be reverted as it's not blocking the work for DomTree updates with a CFGView. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84713/new/ https://reviews.llvm.org/D84713

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

nikic added a comment. This change had a significant negative compile-time impact: https://llvm-compile-time-tracker.com/compare.php?from=0b161def6cacff1a63d3cf1a1efe95b550814d7a&to=e22de4e46d1dd1aacc3a7060d24bcbe89908ba6c&stat=instructions Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe22de4e46d1d: [DominatorTree] Simplify ChildrenGetter. (authored by asbirlea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

asbirlea updated this revision to Diff 281382. asbirlea added a comment. Renamed ChildrenGet to getChildren. The same name only exists in GraphDiff, it's ok to keep a consistent naming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84713/new/ http

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

dblaikie added a comment. In D84713#2177408 , @kuhar wrote: > LGTM. > > One tiny nit: the function name `ChildrenGet` sounds kind of backwards to me, > but it seems like the other direction is already taken. If there are both "ChildrenGet" and "GetChild

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

kuhar accepted this revision. kuhar added a comment. This revision is now accepted and ready to land. LGTM. One tiny nit: the function name `ChildrenGet` sounds kind of backwards to me, but it seems like the other direction is already taken. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

asbirlea created this revision. asbirlea added reviewers: kuhar, dblaikie. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Simplify ChildrenGetter to a simple wrapper around a GraphDiff call. GraphDiff already handles nullptr in children, so the special casing in clang