dblaikie added a comment. In D84713#2177408 <https://reviews.llvm.org/D84713#2177408>, @kuhar wrote:
> LGTM. > > One tiny nit: the function name `ChildrenGet` sounds kind of backwards to me, > but it seems like the other direction is already taken. If there are both "ChildrenGet" and "GetChildren" in the same scope, seems like we probably should address that rather than having one awkwardly named & the ensuing lack of clarity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84713/new/ https://reviews.llvm.org/D84713 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits