[PATCH] D83813: [clang] Teach -fembed-bitcode option not to embed W_value Group

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b42080b51c9: [clang] Teach -fembed-bitcode option not to embed W_value Group (authored by steven_wu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83813/ne

[PATCH] D83813: [clang] Teach -fembed-bitcode option not to embed W_value Group

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83813/new/ https://reviews.llvm.org/D83813 ___ c

[PATCH] D83813: [clang] Teach -fembed-bitcode option not to embed W_value Group

steven_wu updated this revision to Diff 277975. steven_wu added a comment. Use `Option::match` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83813/new/ https://reviews.llvm.org/D83813 Files: clang/lib/Frontend/CompilerInvocation.cpp c

[PATCH] D83813: [clang] Teach -fembed-bitcode option not to embed W_value Group

zixuw added a comment. Would `llvm::Option::matches` be more appropriate than `getID` and checking for equality here? `Option::matches` tracks subgroups correctly, without having to explicitly check for `W_value_Group`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D83813: [clang] Teach -fembed-bitcode option not to embed W_value Group

steven_wu created this revision. steven_wu added reviewers: zixuw, arphaman. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang. -fembed-bitcode options doesn't embed warning options since they are useless to code generation. Make sure it handles the W_value gro