zixuw added a comment.

Would `llvm::Option::matches` be more appropriate than `getID` and checking for 
equality here? `Option::matches` tracks subgroups correctly, without having to 
explicitly check for `W_value_Group`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83813/new/

https://reviews.llvm.org/D83813



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to