[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rG95e43f84b7b9: [AArch64] Add -mmark-bti-property flag. (authored by danielkiss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81930/new/ https://reviews.llv

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

danielkiss marked 4 inline comments as done. danielkiss added a comment. @nickdesaulniers Thanks for the review, comments are addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81930/new/ https://reviews.llvm.org/D81930 ___ cfe-commits

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

danielkiss updated this revision to Diff 291922. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81930/new/ https://reviews.llvm.org/D81930 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/arm64-markbti.S llvm/lib/Target/AArch64/A

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

nickdesaulniers added a comment. I don't have any thoughts on the change per se, so just minor thoughts/generic code review. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6995 + case llvm::Triple::aarch64_be: +if (Arg *A = Args.getLastArg(options::OPT_mmark_bti_proper

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM. It'd be nice if we could get someone non-Arm to have a look too. though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81930/new/ https://reviews.llvm.org/D81930

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

danielkiss updated this revision to Diff 288765. danielkiss marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81930/new/ https://reviews.llvm.org/D81930 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/test/Drive

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

chill added inline comments. Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp:106 + + EmitBTIMarking = MarkBTIProperty.getValue(); } No need to the `.getValue()` part. Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArc

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

danielkiss marked an inline comment as done. danielkiss added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:352 +def FeatureEmitNoteBTIProperty : SubtargetFeature<"markbtiproperty", "MarkBTIProperty", +"true", "Emit .note.gnu.property for Branch Target Id

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

danielkiss updated this revision to Diff 285492. danielkiss added a comment. Fix review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81930/new/ https://reviews.llvm.org/D81930 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/test

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

chill requested changes to this revision. chill added inline comments. This revision now requires changes to proceed. Herald added a subscriber: dang. Comment at: llvm/lib/Target/AArch64/AArch64.td:352 +def FeatureEmitNoteBTIProperty : SubtargetFeature<"markbtiproperty", "Mark

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

danielkiss updated this revision to Diff 272024. danielkiss retitled this revision from "[AArch64] Add -mbti flag." to "[AArch64] Add -mmark-bti-property flag.". danielkiss edited the summary of this revision. danielkiss added a comment. Rename the flag to -mmark-bti-property CHANGES SINCE LAST