chill added inline comments.
================ Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp:106 + + EmitBTIMarking = MarkBTIProperty.getValue(); } ---------------- No need to the `.getValue()` part. ================ Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.h:34 explicit AArch64MCAsmInfoELF(const Triple &T); + bool EmitBTIMarking; }; ---------------- Is there a need for this data member? The option value does not change over time, and the option can be defined in `AArch64TargetStreamer.cpp`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81930/new/ https://reviews.llvm.org/D81930 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
