[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

MaskRay added a comment. In D81865#2293158 , @froydnj wrote: > In D81865#2293146 , @MaskRay wrote: > >> In D81865#2293066 , @dblaikie wrote: >> >>> In D81865#2293059

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. In D81865#2293146 , @MaskRay wrote: > In D81865#2293066 , @dblaikie wrote: > >> In D81865#2293059 , @MaskRay wrote: >> >>> @froydnj The committed ver

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

MaskRay added a comment. In D81865#2293066 , @dblaikie wrote: > In D81865#2293059 , @MaskRay wrote: > >> @froydnj The committed version rG31a3c5fb45b78bdaa78d94ffcc9258e839002016 >>

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

dblaikie added a comment. In D81865#2293059 , @MaskRay wrote: > @froydnj The committed version rG31a3c5fb45b78bdaa78d94ffcc9258e839002016 > appears > to be very different from the revi

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

MaskRay added a comment. @froydnj The committed version rG31a3c5fb45b78bdaa78d94ffcc9258e839002016 appears to be very different from the review. I guess next time your probably can upload the diff again if it is very diffiere

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

This revision was automatically updated to reflect the committed changes. Closed by commit rG31a3c5fb45b7: [clang] use string tables for static diagnostic descriptions (authored by froydnj). Changed prior to commit: https://reviews.llvm.org/D81865?vs=288628&id=294063#toc Repository: rG LLVM

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Herald added a subscriber: danielkiss. Sounds good to me - thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865 __

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj requested review of this revision. froydnj added a comment. Throwing this back into the review queue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj updated this revision to Diff 288628. froydnj added a comment. Updated to use a struct instead of a union for the actual table in an effort to avoid UB. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865 Files: clang/lib/Basic/Diagnostic

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. Ping for an opinion on the recent discussion of how to move forward with this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865 ___

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. Ping for an opinion on the recent discussion of how to move forward with this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865 ___

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

dblaikie added a comment. In D81865#2178542 , @froydnj wrote: > In D81865#2176589 , @dblaikie wrote: > >> I believe this falls under the (using cppreference ( >> https://en.cppreference.com/w/cpp/language/union ) ,

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. In D81865#2176589 , @dblaikie wrote: > I believe this falls under the (using cppreference ( > https://en.cppreference.com/w/cpp/language/union ) , since it's a bit easier > to read) UB clause: " It's undefined behavior to read fr

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

dblaikie added a comment. In D81865#2176148 , @froydnj wrote: > In D81865#2176014 , @bkramer wrote: > > > Nice, those relocations have annoyed me for years. I'm worried about > > whether the way you're accessing St

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. In D81865#2176014 , @bkramer wrote: > Nice, those relocations have annoyed me for years. I'm worried about whether > the way you're accessing StaticDiagInfoDescriptionStringTable might be > undefined behavior. I won't block this

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Nice, those relocations have annoyed me for years. I'm worried about whether the way you're accessing StaticDiagInfoDescriptionStringTable might be undefined behavior. I won't block this cha